[codex] upgrade synapse sdk and core#11
Open
snissn wants to merge 3 commits intocodex/test-synapse-command-coveragefrom
Open
[codex] upgrade synapse sdk and core#11snissn wants to merge 3 commits intocodex/test-synapse-command-coveragefrom
snissn wants to merge 3 commits intocodex/test-synapse-command-coveragefrom
Conversation
…-synapse-sdk-core
There was a problem hiding this comment.
Pull request overview
Upgrades the Synapse SDK/Core dependencies for the foc-cli package and adjusts CLI behavior + output mapping to match the declared schemas, converting the prior TODO regression tests into passing assertions.
Changes:
- Bumped
@filoz/synapse-sdkand@filoz/synapse-core, updatingbun.lockaccordingly. - Updated
multi-uploadto fail the whole request if any input path can’t be read, and documented this requirement. - Fixed schema mismatches in
dataset details(empty metadata) andpiece list(dataSetIdtype), enabling the previously TODO tests.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| skills/foc-cli/SKILL.md | Documents stricter multi-upload behavior (all paths must be readable). |
| cli/tests/synapse-commands.test.ts | Converts TODOs into passing tests for the behavior/schema fixes. |
| cli/src/commands/piece/list.ts | Ensures dataSetId is returned as a string to match the command schema. |
| cli/src/commands/multi-upload.ts | Fails early with FILE_READ_FAILED if any requested file cannot be read. |
| cli/src/commands/dataset/details.ts | Returns metadata as an object consistently (including empty objects). |
| cli/package.json | Upgrades Synapse dependencies. |
| cli/bun.lock | Refreshes lockfile for the upgraded dependency graph / normalized ranges. |
| README.md | Notes multi-upload requires all paths to be readable. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…-synapse-sdk-core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #10. This PR upgrades the Synapse packages after the pre-upgrade command coverage was added, then converts the PR1 TODO coverage into active passing tests by fixing the current behavior gaps those TODOs identified.
What changed
@filoz/synapse-sdkfrom^0.40.0to^0.40.4.@filoz/synapse-corefrom^0.3.1to^0.4.1.bun.lockfor the new Synapse dependency graph. Bun also normalized the rootincurlockfile range to matchpackage.json; the installedincurpackage version is unchanged.multi-uploadfail the request if any requested file path cannot be read, instead of silently uploading only the readable subset.dataset detailsreturn an object for empty piece metadata, matching its declared schema.piece listreturndataSetIdas a string, matching its declared schema.skills/foc-cli/SKILL.mdto note that everymulti-uploadpath must be readable.Test impact
The three TODO tests introduced in #10 are now active tests. The suite has no TODOs and no failures.
Validation
bun install --frozen-lockfilebun run test— 32 pass, 0 failbunx biome check src testsbunx tsc --noEmitbun run buildgit diff --checkStacking note
Base is currently
codex/test-synapse-command-coverageso reviewers can see only the upgrade/fix delta after #10. After #10 lands, this PR can be rebased or retargeted tomain.